[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --en

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.
Date: Tue, 6 Sep 2011 11:35:16 +0100

On 6 September 2011 09:02, Brad <address@hidden> wrote:
> @@ -937,6 +940,7 @@ echo "  --cross-prefix=PREFIX    use PREFIX for compile 
> tools [$cross_prefix]"
>  echo "  --cc=CC                  use C compiler CC [$cc]"
>  echo "  --host-cc=CC             use C compiler CC [$host_cc] for code run 
> at"
>  echo "                           build time"
> +echo "  --optflags=FLAGS         override optimization compiler flags"
>  echo "  --extra-cflags=CFLAGS    append extra C compiler flags QEMU_CFLAGS"
>  echo "  --extra-ldflags=LDFLAGS  append extra linker flags LDFLAGS"
>  echo "  --make=MAKE              use specified make [$make]"

No in principle objection to the --optflags bit of the patch, but you
should rearrange things so that the help message can include the
default optflags, something like:
  --optflags=FLAGS    specify compiler flags for optimization [-O2]

(...which might also let you avoid the 'if test -n "$optflags" later.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]