[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --en

From: Brad
Subject: Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.
Date: Tue, 06 Sep 2011 12:30:51 -0400

----- Original message -----
> On 09/06/11 10:02, Brad wrote:
> > Only build with -g CFLAGS/LDFLAGS if using --enable-debug.
> > Add --optflags to allow overriding the default optimization
> > level added to CFLAGS.
> > 
> > This is a first draft of coming up with a patch I could potentially
> > push upstream based on much cruder local patches to do something
> > similar. I'm trying to eliminate having to patch the configure
> > script.
> You don't have to.   You can just run 'make CFLAGS="$optflags"' to 
> override the defaults.   Nevertheless having optflags would be nice as 
> you don't have to type this for each make run then.

I do when its unconditionally on the commandline either way. If the configure 
scipt didnt put it their if CFLAGS wasnt empty it wouldnt be an issue.

> I don't think we should mess with the -g flag.   It should stay enabled 
> by default, so you can easily get a useful stacktrace out of a core 
> without having to rebuild with debug info first.

I dont care what the default is as long as I can disable it without patching.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]