[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --en

From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.
Date: Wed, 07 Sep 2011 23:31:38 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110818 Iceowl/1.0b1 Icedove/3.0.11

Am 06.09.2011 18:30, schrieb Brad:
----- Original message -----
On 09/06/11 10:02, Brad wrote:
Only build with -g CFLAGS/LDFLAGS if using --enable-debug.
Add --optflags to allow overriding the default optimization
level added to CFLAGS.

This is a first draft of coming up with a patch I could potentially
push upstream based on much cruder local patches to do something
similar. I'm trying to eliminate having to patch the configure

You don't have to.  You can just run 'make CFLAGS="$optflags"' to
override the defaults.  Nevertheless having optflags would be nice as
you don't have to type this for each make run then.

I do when its unconditionally on the commandline either way. If the configure scipt didnt put it their if CFLAGS wasnt empty it wouldnt be an issue.

I don't think we should mess with the -g flag.  It should stay enabled
by default, so you can easily get a useful stacktrace out of a core
without having to rebuild with debug info first.

I dont care what the default is as long as I can disable it without patching.

I'm sorry but I still don't understand why you want this patch.
It's already possible to run the compiler with or without -g
and with any optimization you want: make CFLAGS="-O1",
make CFLAGS=-g (my favourite), make CFLAGS="-O0", ...

There must be a really good reason for new options like
--optflags. Is this flag some kind of standard which is widely
used (like CFLAGS)? If it isn't, users won't know it, so they
won't use it, so it is useless.

Stefan Weil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]