[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new
Date: Thu, 24 May 2012 07:58:05 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 05/24/2012 06:51 AM, Paolo Bonzini wrote:
Il 24/05/2012 13:43, Markus Armbruster ha scritto:
Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack
additional magic performed by qdev_try_create(), and almost certainly
won't work.

True.  With the patches on the list, all that adev_try_create does is really

     dev->parent_bus = bus;
     bus_add_child(bus, dev);

We should change that to a parent_bus property,

parent_bus is a property with the QOM bus series (which is part of your Push, push, series, no?).

You still can't add a bus as a child. We need a magic child[*] link that acts like a clone file. Shouldn't be hard to add.


Anthony Liguori

 so that device_add is
really qom-new + qom-set parent_bus.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]