[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types
Date: Wed, 11 Jul 2012 14:49:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0

Am 08.07.2012 21:22, schrieb address@hidden:
> From: Blue Swirl <address@hidden>
> Use 'unsigned int' for bit numbers instead of 'unsigned long' or
> 'int'. Adjust asserts.
> Signed-off-by: Blue Swirl <address@hidden>

I haven't followed the original discussion and therefore don't know what
the controversy is about (nor do I feel like reading it up), but if
there is no consensus, I would expect even more than already for normal
patches that the commit message doesn't only state the obvious change,
but also the reasons for the change.

This message isn't much different from the famous "i++; /* increase i by
one */" code comment.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]