[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions tha
Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void
Wed, 13 Apr 2016 09:38:14 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
On 13/04/2016 08:33, Markus Armbruster wrote:
> * Look for functions that are named *_exit or *_exitfn in hw/ and that
> return int. They should all return zero. Make them return void, and
> remove the checks for the callers.
... and change the exit method to "void fn(void)"
> * Once the above change is done, remove the "Error **" argument from
> functions named *_unrealize in hw/
... same for the unrealize method.
> Added by Paolo on 2014-12-03. These tasks don't make sense to me.
> Paolo, can you explain?
The exit functions always return zero, the unrealize functions never
touch the Error** argument. So make both of them "void fn(void)" and
remove the difference between exit and unrealize.