[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions tha

From: Markus Armbruster
Subject: Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void
Date: Wed, 13 Apr 2016 13:29:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> On 13/04/2016 08:33, Markus Armbruster wrote:
>> * Look for functions that are named *_exit or *_exitfn in hw/ and that
>>   return int.  They should all return zero.  Make them return void, and
>>   remove the checks for the callers.
>       ... and change the exit method to "void fn(void)"
>> * Once the above change is done, remove the "Error **" argument from
>>   functions named *_unrealize in hw/
>      ... same for the unrealize method.
>> Added by Paolo on 2014-12-03.  These tasks don't make sense to me.
>> Paolo, can you explain?
> The exit functions always return zero, the unrealize functions never
> touch the Error** argument.  So make both of them "void fn(void)" and
> remove the difference between exit and unrealize.

Got it now, thanks!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]