[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors
Date: Thu, 16 Jun 2016 11:20:13 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 06/16/2016 08:46 AM, Markus Armbruster wrote:
> Markus Armbruster <address@hidden> writes:
>> Eric Blake <address@hidden> writes:
>>> Rather than having two separate visitor callbacks with items
>>> already broken out, pass the actual QAPISchemaObjectType object
>>> to the visitor.  This lets the visitor access things like
>>> type.is_implicit() without needing another parameter, resolving
>>> a TODO from previous patches.
>>> For convenience and consistency, the 'name' and 'info' parameters
>>> are still provided, even though they are now redundant with
>>> 'typ.name' and 'typ.info'.
>>> Signed-off-by: Eric Blake <address@hidden>
>> We've seen this one before :)

>> End quote.  Let's see how this series profits from the patch, and
>> whether we want to change the other visit methods as well for
>> consistency.
> Where is this used in the rest of the series?

Hmm, I don't know that it actually makes a difference, unless we expand
its scope to also do the same things for commands and events (rather
than adding a 'box' parameter to those callbacks).

And deferring it doesn't break things anywhere else in this series.  I
guess we drop it.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]