[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors
Date: Fri, 17 Jun 2016 09:39:02 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 06/16/2016 08:46 AM, Markus Armbruster wrote:
>> Markus Armbruster <address@hidden> writes:
>>> Eric Blake <address@hidden> writes:
>>>> Rather than having two separate visitor callbacks with items
>>>> already broken out, pass the actual QAPISchemaObjectType object
>>>> to the visitor.  This lets the visitor access things like
>>>> type.is_implicit() without needing another parameter, resolving
>>>> a TODO from previous patches.
>>>> For convenience and consistency, the 'name' and 'info' parameters
>>>> are still provided, even though they are now redundant with
>>>> 'typ.name' and 'typ.info'.
>>>> Signed-off-by: Eric Blake <address@hidden>
>>> We've seen this one before :)
>>> End quote.  Let's see how this series profits from the patch, and
>>> whether we want to change the other visit methods as well for
>>> consistency.
>> Where is this used in the rest of the series?
> Hmm, I don't know that it actually makes a difference, unless we expand
> its scope to also do the same things for commands and events (rather
> than adding a 'box' parameter to those callbacks).
> And deferring it doesn't break things anywhere else in this series.  I
> guess we drop it.

Let's keep it on the shelf for now.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]