[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our o

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers
Date: Fri, 24 Jun 2016 08:54:34 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 06/24/2016 08:19 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>

Worth mentioning how you found the culprits in the commit message, so
that someone could repeat the task when backporting this patch or
dealing with future cruft that inevitably creeps back in without an
automated checkin validation tool?

> +++ b/crypto/pbkdf-nettle.c
> @@ -19,9 +19,9 @@
>   */
>  #include "qemu/osdep.h"
> +#include <nettle/pbkdf2.h>
>  #include "qapi/error.h"
>  #include "crypto/pbkdf.h"
> -#include "nettle/pbkdf2.h"

You're not just converting <> to "" (when the header is internal) or ""
to <> (when the header is 3rd-party), but also rearranging things to put
<> before "" (except for osdep.h which must be first).  I like that
paradigm, but again, might be worth a mention in the commit message as
being intentional.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]