[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our o
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers |
|
Date: |
Tue, 28 Jun 2016 10:17:22 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On 27 June 2016 at 09:50, Markus Armbruster <address@hidden> wrote:
>> To spice up things, we
>> also name a few of our headers just like system headers we use
>> elsewhere, e.g. "util.h" in net/ vs. <util.h> in util/qemu-openpty.c.
>
> That would be nice to fix at some point I think, it's pretty brittle.
> (We had one issue recently that boiled down to system header vs local
> header confusion, though I forget the details.)
Fixing collisions we're aware of is easy enough, just rename our header.
Finding collisions is more interesting. Perhaps I can cook up something
for make check-source.
[Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony target, Markus Armbruster, 2016/06/24
[Qemu-devel] [PATCH RFC v2 5/5] include: Include exec/hwaddr.h where hwaddr is used, Markus Armbruster, 2016/06/24
[Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source, Markus Armbruster, 2016/06/24