[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our o

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers
Date: Mon, 27 Jun 2016 08:34:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 06/24/2016 08:19 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Peter Maydell <address@hidden>
> Worth mentioning how you found the culprits in the commit message, so
> that someone could repeat the task when backporting this patch or
> dealing with future cruft that inevitably creeps back in without an
> automated checkin validation tool?
>> +++ b/crypto/pbkdf-nettle.c
>> @@ -19,9 +19,9 @@
>>   */
>>  #include "qemu/osdep.h"
>> +#include <nettle/pbkdf2.h>
>>  #include "qapi/error.h"
>>  #include "crypto/pbkdf.h"
>> -#include "nettle/pbkdf2.h"
> You're not just converting <> to "" (when the header is internal) or ""
> to <> (when the header is 3rd-party), but also rearranging things to put
> <> before "" (except for osdep.h which must be first).  I like that
> paradigm, but again, might be worth a mention in the commit message as
> being intentional.

Our ordering of #include directives looks and smells like an open
garbage dump in August.  Cleaning this up should become feasible once we
manage to make our headers self-contained.  If such a cleanup is wanted.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]