[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines
From: |
Artyom Tarasenko |
Subject: |
Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines |
Date: |
Tue, 11 Oct 2016 15:51:03 +0200 |
On Tue, Oct 11, 2016 at 7:50 AM, Richard Henderson <address@hidden> wrote:
> On 10/10/2016 04:45 PM, Artyom Tarasenko wrote:
>>>
>>> Hmm. Would it make more sense to reorg these as
>>>
>>> TTE_US1_*
>>> TTE_UA2005_*
>>>
>>> with some duplication for the bits that are shared?
>>> As is, it's pretty hard to tell which actually change...
>>
>>
>> All of them :-)
>> I'm not sure about renaming: the US1 format is still used in T1 on the
>> read
>> access.
>>
>> On the other hand, it's not used in T2. And then again we don't have the
>> T2
>> emulation yet.
>
>
> Oh my. Different on T2 as well?
T2 has more used bits, and can not use the US1 format, I think.
> I wonder if it would make sense to have different functions with which to
> fill in the CPUClass hooks (or invent new SPARCCPUClass hooks as necessary)
> for the major entry points.
>
> E.g. sparc_cpu_handle_mmu_fault or get_physical_address could be hooked, so
> that the choice of how to handle the tlb miss is chosen at startup time, and
> not during each fault. One can arrange subroutines as necessary to share
> code between the alternate routines, such as when T1 needs to use parts of
> US1.
Yes, I plan to do it once I get to T2 emulation.
> Similarly for out-of-line ASI handling, which is already beyond messy, with
> handling for all cpus thrown in the same switch statement.
Yes. I think we need to split SPARCv9 standard ASIs from CPU-specific
ones, call cpu-specific handlers first and standard handler
afterwards.
But not in this series.
Artyom
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
- Re: [Qemu-devel] [PATCH 01/29] target-sparc: don't trap on MMU-fault if MMU is disabled, (continued)
[Qemu-devel] [PATCH 02/29] target-sparc: use explicit mmu register pointers, Artyom Tarasenko, 2016/10/01
[Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Artyom Tarasenko, 2016/10/01
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/10
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Artyom Tarasenko, 2016/10/10
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/11
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines,
Artyom Tarasenko <=
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/11
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Artyom Tarasenko, 2016/10/12
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/12
[Qemu-devel] [PATCH 04/29] target-sparc: add UltraSPARC T1 TLB #defines, Artyom Tarasenko, 2016/10/01
[Qemu-devel] [PATCH 06/29] target-sparc: simplify replace_tlb_entry by using TTE_PGSIZE, Artyom Tarasenko, 2016/10/01
[Qemu-devel] [PATCH 05/29] target-sparc: on UA2005 don't deliver Interrupt_level_n IRQs in hypervisor mode, Artyom Tarasenko, 2016/10/01
[Qemu-devel] [PATCH 08/29] target-sparc: implement UltraSPARC-T1 Strand status ASR, Artyom Tarasenko, 2016/10/01