|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v2 5/5] target-m68k: Implement bitfield ops for memory |
Date: | Mon, 28 Nov 2016 08:26:08 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/27/2016 11:48 AM, Laurent Vivier wrote: >> > + return (int64_t)(data << d.bofs) >> (64 - len); > We must use d.len instead of len, otherwise we shift with 32bit value. > > - return (int64_t)(data << d.bofs) >> (64 - len); > + return (int64_t)(data << d.bofs) >> (64 - d.len); Whoops, yes. r~
[Prev in Thread] | Current Thread | [Next in Thread] |