[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul(

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks
Date: Thu, 16 Feb 2017 14:07:09 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 02/14/2017 04:25 AM, Markus Armbruster wrote:
>> Use unsigned comparisons to check the result of qemu_strtoul() and
>> strtoull().
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/test-cutils.c | 60 
>> ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 30 insertions(+), 30 deletions(-)
> No real difference except when the test fails (better printed result if
> the number being printed exceeds the max signed counterpart value), but
> never hurts to be more precise.

Sadly, my version of glib prints signed all the same.

I'll use g_assert_cmphex() where useful in v2.

> Reviewed-by: Eric Blake <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]