[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/24] tests/test-cutils: Cover qemu_strtosz() i

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 11/24] tests/test-cutils: Cover qemu_strtosz() invalid input
Date: Thu, 16 Feb 2017 15:19:57 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 02/14/2017 04:25 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/test-cutils.c | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
> Perhaps you could also add a test of "-".  Either way,

The test cases match the ones for qemu_strtol() & friends:
test_qemu_stro*_{empty,whitespace,invalid}().  If we add "-" here, we
should probably add it there as well.  I think we totally should if we
were testing a strtol() implementation.  But we're only testing a
wrapper, and other test cases cover the "strtol() fails without
converting anything" case, so I think we're okay.

> Reviewed-by: Eric Blake <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]