[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py
Date: Tue, 14 Mar 2017 08:26:45 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> This reverts commit 3313b61's changes to tests/qapi-schema/, except
>> for tests/qapi-schema/doc-*.
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
> Tested by doing:
> $ git checkout 3313b61
> $ git cherry-pick 07c7b92 # the current id on your qapi-doc branch
> $ git diff HEAD^^ --stat tests/qapi-schema | grep -v /doc-
>  72 files changed, 164 insertions(+)
> Reviewed-by: Eric Blake <address@hidden>
>>  200 files changed, 92 insertions(+), 1074 deletions(-)
> It's a shame we did that much busywork adding test documentation in the
> first place.  But it was incomplete (as I found out when trying to
> convert some existing tests of failures into new tests of success, by
> adding features like anonymous bases to flat unions), and indeed does
> not add much value.

Marc-André initially reported missing documentation errors only in
qapi2texi.py.  I asked why in review of v5, he pointed to tests, I said
"good point" and asked to put the explanation in the commit message.
Got back "I fixed the tests instead (after all, we have complete control
on what to accept or not. that was boring but now it's done)", felt a
bit bad, and then felt bad some more when I made this patch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]