[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 6

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts
Date: Fri, 28 Apr 2017 09:07:38 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0

On 04/27/2017 06:10 PM, Alex Bennée wrote:

Richard Henderson <address@hidden> writes:

We need to coordinate with the TCG_OVERSIZED_GUEST test in cputlb.c,
and allow 64-bit atomics even though sizeof(void *) == 4.

Hmm you say this here but we never actually do it. But the other changes
seem fine.

I don't understand this comment.

+#if defined(__x86_64__) || defined(__sparc__)
+# define ATOMIC_REG_SIZE  8
+# define ATOMIC_REG_SIZE  sizeof(void *)

How does this "never actually do it"?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]