[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 6

From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts
Date: Fri, 28 Apr 2017 11:25:30 +0100
User-agent: mu4e 0.9.19; emacs 25.2.17

Richard Henderson <address@hidden> writes:

> On 04/28/2017 09:47 AM, Alex Bennée wrote:
>> So maybe the comment should be clearer for ATOMIC_REG_SIZE that it
>> should match TCG_TARGET_REG_BITS (and therefore sync with
>> TCG_OVERSIZED_GUEST) in the atomic.h comment.
> How about
>  * That said, we have a problem on 64-bit ILP32 hosts in that in order to
>  * sync with TCG_OVERSIZED_GUEST, this must match TCG_TARGET_REG_BITS.
>  * We'd prefer not want to pull in everything else TCG related, so handle
>  * those few cases by hand.
> ?

Sounds good to me.

Reviewed-by: Alex Bennée <address@hidden>

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]