[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 22/23] tests: qmp-test: verify command batching
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH v8 22/23] tests: qmp-test: verify command batching |
Date: |
Fri, 9 Mar 2018 17:00:05 +0800 |
OOB introduced DROP event for flow control. This should not affect old
QMP clients. Add a command batching check to make sure of it.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
tests/qmp-test.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 70d1152d32..caf3ec4a78 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -82,6 +82,7 @@ static void test_qmp_protocol(void)
QTestState *qts;
const QListEntry *entry;
QString *qstr;
+ int i;
qts = qtest_init_without_qmp_handshake(common_args);
@@ -139,6 +140,27 @@ static void test_qmp_protocol(void)
g_assert_cmpint(qdict_get_int(resp, "id"), ==, 2);
QDECREF(resp);
+ /*
+ * Test command batching. In current test OOB is not enabled, we
+ * should be able to run as many commands in batch as we like.
+ * Using 16 (>8, which is OOB queue length) to make sure OOB won't
+ * break existing clients. Note: this test does not control the
+ * scheduling of QEMU's QMP command processing threads so it may
+ * not really trigger batching inside QEMU. This is just a
+ * best-effort test.
+ */
+ for (i = 0; i < 16; i++) {
+ qtest_async_qmp(qts, "{ 'execute': 'query-version' }");
+ }
+ /* Verify the replies to make sure no command is dropped. */
+ for (i = 0; i < 16; i++) {
+ resp = qtest_qmp_receive(qts);
+ /* It should never be dropped. Each of them should be a reply. */
+ g_assert(qdict_haskey(resp, "return"));
+ g_assert(!qdict_haskey(resp, "event"));
+ QDECREF(resp);
+ }
+
qtest_quit(qts);
}
--
2.14.3
- Re: [Qemu-devel] [PATCH v8 15/23] qmp: add new event "command-dropped", (continued)
- [Qemu-devel] [PATCH v8 17/23] qapi: introduce new cmd option "allow-oob", Peter Xu, 2018/03/09
- [Qemu-devel] [PATCH v8 18/23] qmp: support out-of-band (oob) execution, Peter Xu, 2018/03/09
- [Qemu-devel] [PATCH v8 19/23] qmp: isolate responses into io thread, Peter Xu, 2018/03/09
- [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Peter Xu, 2018/03/09
- [Qemu-devel] [PATCH v8 21/23] qmp: add command "x-oob-test", Peter Xu, 2018/03/09
- [Qemu-devel] [PATCH v8 22/23] tests: qmp-test: verify command batching,
Peter Xu <=
- [Qemu-devel] [PATCH v8 23/23] tests: qmp-test: add oob test, Peter Xu, 2018/03/09
- Re: [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support, Eric Blake, 2018/03/10
- Re: [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support, Eric Blake, 2018/03/12