Re: [Qemu-devel] [PATCH v8 21/23] qmp: add command "x-oob-test"

[Eric Blake]

On 03/09/2018 03:00 AM, Peter Xu wrote:
> This command is only used to test OOB functionality.  It should not be
> used for any other purposes.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
>   qapi/misc.json | 18 ++++++++++++++++++
>   qmp.c          | 16 ++++++++++++++++
>   2 files changed, 34 insertions(+)
>
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 8c7e736681..07932bdacf 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -3264,3 +3264,21 @@
>   ##
>   { 'event': 'COMMAND_DROPPED' ,
>     'data': { 'id': 'any', 'reason': 'CommandDropReason' } }
> +
> +##
> +# @x-oob-test:
> +#
> +# Test OOB functionality.  When send this command with lock=true,

s/send/sending/

> +# it'll try to hang the dispatcher.  When send it with lock=false,

s/send/sending/

> +# it'll try to notify the locked thread to continue.  Note: it should
> +# only be used by QMP test program rather than anything else.
> +#
> +# Since: 2.12
> +#
> +# Example:
> +#
> +# { "execute": "x-oob-test",
> +#   "arguments": { "lock": true } }
> +##
> +{ 'command': 'x-oob-test', 'data' : { 'lock': 'bool' },
> +  'allow-oob': true }
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org