[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution suppo

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support
Date: Sat, 10 Mar 2018 20:59:38 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/09/2018 02:59 AM, Peter Xu wrote:
Based-on: <address@hidden>

The series is based on the following series:

   [PATCH v2 0/9] chardev: qio related non-default context support
   (actually patch 9 is based on version 2.1, Dan's version)

This version only contains some trivial changes, most of the work is
posted separately in either the QIO or CHARDEV series.

Four days until soft freeze.  Hmm...

Please review.  Thanks,

- fix up doc patch as suggested [Eric]
- rename functions in form of X_get_Y() or X_bh() [Stefan]
- English fixes [Stefan]
- make sure to kick iothread after suspend count update [Stefan]
- remove the hack to remove fd in monitor_init(), since now we have
   the QIO/CHARDEV series to solve the root problem.

Still a lot that I had to clean up (in part due to conflicts with other pending patches that also touch qapi), but given the utility of this feature, and the impending deadline for freeze, I've gone ahead and done the cleanup work. Your patches are now stages on my QAPI tree.

git://repo.or.cz/qemu/ericb.git qapi

Note that I had some ideas for followup patches (mainly strengthening the testsuite, which is typically safe early on in freeze because it is not introducing features but strengthening the quality of the release).

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]