[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 16/35] target/arm: Implement SVE floating-poi

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v5 16/35] target/arm: Implement SVE floating-point compare vectors
Date: Tue, 26 Jun 2018 09:41:41 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/25/2018 10:20 AM, Peter Maydell wrote:
>> +#define DO_FCMGE(TYPE, X, Y, ST)  TYPE##_compare(Y, X, ST) <= 0
> I was expecting the RHS of this to be TYPE##_le(Y, X, ST).
> This prompted me to notice that softfloat has as well as
> the generic 'compare' routines also specialized _le/lt/unordered
> etc functions for float64 and float32 but not float16, which is
> a bit inconsistent...

Yes.  I have a mild preference to using floatN_compare everywhere and removing
the other functions entirely.  But that's a medium sized job across multiple
targets.  I also agree that in the meantime the inconsistency is surprising.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]