[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/32] qmp: Make "id" optional again even in "oo
Re: [Qemu-devel] [PATCH 07/32] qmp: Make "id" optional again even in "oob" monitors
Tue, 3 Jul 2018 11:36:25 +0800
On Mon, Jul 02, 2018 at 06:21:53PM +0200, Markus Armbruster wrote:
> Commit cf869d53172 "qmp: support out-of-band (oob) execution" made
> "id" mandatory for all commands when the client accepted capability
> "oob". This is rather onerous when you play with QMP by hand, and
> unnecessarily so: only out-of-band commands need an ID for reliable
> matching of response to command.
> Revert that part of commit cf869d53172 for now. We may still make
> "id" mandatory for out-of-band commands.
This change should be okay with current implementation when
out-of-band commands are still in order themselves, though I'm still
not that confident on whether we really want this change if only for
the sake of easier usage for human beings.
If we see Libvirt, the real player for QMP - it has the "id" field
even for in-band commands always. I'd say the "id" field is really
helpful for machines, though not that friendly to us.
Basically I'll read it as: machines like "id"s, humans hate "id"s.
And QMP is Qemu Machine Protocol after all... so not sure whether
it'll be good we change that for us humans.