[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it i

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it is compiled in
Date: Fri, 10 Aug 2018 14:11:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 10/08/2018 13:08, Juan Quintela wrote:
>> Emanuele's qos-test would do this automatically.  It would be nicer to
>> convert the whole ISA subsystem to use libqos and qos-test...
> Can we get this in until we get some volunteer for that other work?
> /me full of things on his plate at the moment.

Sure, but since this is RFC, I commented. :)  With qos-test, all tests
end up in a single binary that is generic for all QEMU targets, and
there's no need to synchronize the configuration with the testing.

The disadvantage of doing it at the Makefile level is that it relies on
the devices being either in all targets or none.  For example
CONFIG_ISA_TESTDEV cannot be removed from just
default-configs/ppc-softmmu.mak if you are building both a PPC and an
x86 target.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]