[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it i

From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it is compiled in
Date: Fri, 10 Aug 2018 17:17:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Paolo Bonzini <address@hidden> wrote:
> On 10/08/2018 13:08, Juan Quintela wrote:
>>> Emanuele's qos-test would do this automatically.  It would be nicer to
>>> convert the whole ISA subsystem to use libqos and qos-test...
>> Can we get this in until we get some volunteer for that other work?
>> /me full of things on his plate at the moment.
> Sure, but since this is RFC, I commented. :)

I didn't expect less of you O:-)

> With qos-test, all tests
> end up in a single binary that is generic for all QEMU targets, and
> there's no need to synchronize the configuration with the testing.
> The disadvantage of doing it at the Makefile level is that it relies on
> the devices being either in all targets or none.  For example
> CONFIG_ISA_TESTDEV cannot be removed from just
> default-configs/ppc-softmmu.mak if you are building both a PPC and an
> x86 target.

I can live with that.  My use case is:
- complining for more than one architecture: everything
  under the sun is compiled in
- development: I choose a single architecture and the minimal amount of
  devices for whatever I am testing

So, for me is perfect, thanks.

Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]