[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

From: Simon Ruderich
Subject: Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command
Date: Thu, 16 Aug 2018 10:13:20 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

On Thu, Aug 16, 2018 at 07:43:41AM +0200, Markus Armbruster wrote:
>> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
>>> Also, had you considered rearranging and making them optional,
>>> for example if you do:
>>> val:l,filename:F,offset:i?,size:i?
>>> I think that would mean you can do the fairly obvious:
>>>   pmemload addr "myfile"
>>> with the assumption that loads the whole file.
>> This would deviate from pmemsave/memsave, but feels more natural.
> The different order or arguments in HMP is somewhat ugly.  Okay if it
> makes the command more pleasant to use.  Up to you and Dave to decide.
> If you decide to deviate, consider
>     filename:F,address:l,size:i?,offset:i?

From what I understand we can't have optional arguments in the
middle. Would you prefer mandatory size/offset parameters in HMP
or optional parameters but inconsistent with pmemsave/memsave?
Both works for me.

+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]