Re: [Qemu-devel] [PATCH v2 21/60] json: Reject invalid UTF-8 sequences

[Eric Blake]

On 08/17/2018 10:05 AM, Markus Armbruster wrote:
> We reject bytes that can't occur in valid UTF-8 (\xC0..\xC1,
> \xF5..\xFF in the lexer.  That's insufficient; there's plenty of
> invalid UTF-8 not containing these bytes, as demonstrated by
> check-qjson:
>
> * Malformed sequences
>
>    - Unexpected continuation bytes
>
>    - Missing continuation bytes after start bytes other than
>      \xC0..\xC1, \xF5..\xFD.
>
> * Overlong sequences with start bytes other than \xC0..\xC1,
>    \xF5..\xFD.
>
> * Invalid code points
>
> Fixing this in the lexer would be bothersome.  Fixing it in the parser
> is straightforward, so do that.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org