[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 25/60] json: Leave rejecting invalid escape s

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 25/60] json: Leave rejecting invalid escape sequences to parser
Date: Fri, 17 Aug 2018 11:32:28 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 08/17/2018 10:05 AM, Markus Armbruster wrote:
Both lexer and parser reject invalid escape sequences in strings.  The
parser's check is useless.

While there, fix parse_string()'s inaccurate function comment.

Signed-off-by: Markus Armbruster <address@hidden>

+ * From RFC 7159 "The JavaScript Object Notation (JSON) Data
+ * Interchange Format":

You did point out in the cover letter that you intend to rewrite this to point to 8259. (That's saying something - when portions of these patches have been around on our mailing list prior to the point of the RFC being updated). Here, and elsewhere in the series, that's minor enough that I don't see it invalidating any of my R-b.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]