[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/17] job: Fix missing locking due to mismer
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 01/17] job: Fix missing locking due to mismerge |
|
Date: |
Thu, 13 Sep 2018 15:56:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 13.09.18 14:52, Kevin Wolf wrote:
> job_completed() had a problem with double locking that was recently
> fixed independently by two different commits:
>
> "job: Fix nested aio_poll() hanging in job_txn_apply"
> "jobs: add exit shim"
>
> One fix removed the first aio_context_acquire(), the other fix removed
> the other one. Now we have a bug again and the code is run without any
> locking.
>
> Add it back in one of the places.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> job.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature