[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/7] fp-bench: remove wrong exponent raise in fill_ra
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 2/7] fp-bench: remove wrong exponent raise in fill_random |
Date: |
Thu, 17 Jan 2019 13:26:58 +0000 |
From: "Emilio G. Cota" <address@hidden>
At this point random_ops[] only contains normals, so there's
no need to do anything to them. In fact, raising the exponent
here can make the output !normal, which is precisely
what the comment says we want to avoid.
Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c
index 546bac9c9c..4ba5e1d2d4 100644
--- a/tests/fp/fp-bench.c
+++ b/tests/fp/fp-bench.c
@@ -176,8 +176,6 @@ static void fill_random(union fp *ops, int n_ops, enum
precision prec,
if (no_neg && float32_is_neg(ops[i].f32)) {
ops[i].f32 = float32_chs(ops[i].f32);
}
- /* raise the exponent to limit the frequency of denormal results */
- ops[i].f32 |= 0x40000000;
break;
case PREC_DOUBLE:
case PREC_FLOAT64:
@@ -185,8 +183,6 @@ static void fill_random(union fp *ops, int n_ops, enum
precision prec,
if (no_neg && float64_is_neg(ops[i].f64)) {
ops[i].f64 = float64_chs(ops[i].f64);
}
- /* raise the exponent to limit the frequency of denormal results */
- ops[i].f64 |= LIT64(0x4000000000000000);
break;
default:
g_assert_not_reached();
--
2.17.1
- [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 7/7] tests/Makfile: add check-softfloat rule, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 5/7] tests/Makefile: add floating point tests, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 4/7] include/fpu/softfloat: Fix compilation with Clang on s390x, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 3/7] softfloat: enforce softfloat if the host's FMA is broken, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 6/7] scripts/archive-source: include softfloat tests, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 1/7] fp-bench: fix update_random_ops, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 2/7] fp-bench: remove wrong exponent raise in fill_random,
Alex Bennée <=
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Peter Maydell, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Emilio G. Cota, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Peter Maydell, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Emilio G. Cota, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Alex Bennée, 2019/01/18
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Peter Maydell, 2019/01/18
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Emilio G. Cota, 2019/01/18
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Alex Bennée, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Philippe Mathieu-Daudé, 2019/01/18
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Alex Bennée, 2019/01/18