Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

[Peter Maydell]

On Thu, 17 Jan 2019 at 13:27, Alex Bennée <address@hidden> wrote:
>
> The following changes since commit 4b9f0b0f7c84eea2dfb0d5be3e0254bc91319dbc:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' 
> into staging (2019-01-15 17:24:00 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/stsquad/qemu.git tags/pull-fpu-next-170119-1
>
> for you to fetch changes up to f722d6877d4e91e984480a4b687cf12971b6c931:
>
>   tests/Makfile: add check-softfloat rule (2019-01-17 09:12:33 +0000)
>
> ----------------------------------------------------------------
> Some more softfloat/fpu fixes
>
>    - make check-softfloat
>    - fixes for fp-bench
>    - workaround broken host fma
>    - compile fix for s390x/clang
>
> ----------------------------------------------------------------

FreeBSD, OSX, x86-64 Linux clang builds:

Lots of these trying to build code in tests/fp:

warning: unknown warning option '-Wno-discarded-qualifiers'; did you
mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-maybe-uninitialized'; did you
mean '-Wno-uninitialized'? [-Wunknown-warning-option]


/var/tmp/qemu-test.Z0AmK8/tests/fp/berkeley-testfloat-3/source/fail.c:44:7:
warning: initializing 'char *' with an expression of type 'const char
[1]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
char *fail_programName = "";
      ^                  ~~


fp-test.c:905:33: warning: incompatible pointer types assigning to
'uint_fast8_t (*)(void)' (aka 'unsigned int (*)(void)') from 'uint8_t
(void)' (aka 'unsigned char (void)') [-Wincompatible-pointer-types]
    testLoops_trueFlagsFunction = slow_clear_flags;
                                ^ ~~~~~~~~~~~~~~~~
fp-test.c:906:33: warning: incompatible pointer types assigning to
'uint_fast8_t (*)(void)' (aka 'unsigned int (*)(void)') from 'uint8_t
(void)' (aka 'unsigned char (void)') [-Wincompatible-pointer-types]
    testLoops_subjFlagsFunction = qemu_clear_flags;
                                ^ ~~~~~~~~~~~~~~~~


PPC64, AArch64:
 * same warning about discarding 'const' in fail.c as above
 * cc1: warning: unrecognized command line option
"-Wno-discarded-qualifiers" [enabled by default]

NetBSD:
 * same warning about slow_clear_flags/qemu_clear_flags assignments

S390X host:
Looks like a failure running the tests, but no diagnostics about
what exactly went wrong or clear "test failed" indicator:

cd /home/linux1/qemu/build/all/tests/fp && ./fp-test -s -l 1
i32_to_f16 i64_to_f16 i32_to_f32 i64_t
o_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 >
int-to-float.out 2>  int-to-float.err
/home/linux1/qemu/tests/Makefile.include:913: recipe for target
'check-softfloat-conv' failed
make: *** [check-softfloat-conv] Error 1

thanks
-- PMM