Re: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
79d073df01 target/riscv: Remaining rvc insn reuse 32 bit translators
149a4e77e7 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
c378cd6332 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
c2f98fed12 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
d0651d3ced target/riscv: Convert @cs_2 insns to share translation functions
5c1ce86bf7 target/riscv: Remove decode_RV32_64G()
1252c0978f target/riscv: Remove gen_system()
9de09ac79d target/riscv: Rename trans_arith to gen_arith
f0b34b5843 target/riscv: Remove manual decoding of RV32/64M insn
bfa8a3fdf7 target/riscv: Remove shift and slt insn manual decoding
acf34a297c target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
57547a0f0d target/riscv: Move gen_arith_imm() decoding into trans_* functions
cca0e9bc81 target/riscv: Remove manual decoding from gen_store()
18873e6110 target/riscv: Remove manual decoding from gen_load()
bd963236b9 target/riscv: Remove manual decoding from gen_branch()
0caa845fcc target/riscv: Remove gen_jalr()
b753bbf2f3 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
e13984b314 target/riscv: Convert quadrant 1 of RVXC insns to decodetree
c26e3fb706 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
1fba6972de target/riscv: Convert RV priv insns to decodetree
76465c2a96 target/riscv: Convert RV64D insns to decodetree
0e2c2360fc target/riscv: Convert RV32D insns to decodetree
f65c343c00 target/riscv: Convert RV64F insns to decodetree
eb79c070af target/riscv: Convert RV32F insns to decodetree
1672d35f94 target/riscv: Convert RV64A insns to decodetree
bba2c8eee0 target/riscv: Convert RV32A insns to decodetree
dfafa8effa target/riscv: Convert RVXM insns to decodetree
e6a9b9eb65 target/riscv: Convert RVXI csr insns to decodetree
2816db131b target/riscv: Convert RVXI fence insns to decodetree
e1eb41a99d target/riscv: Convert RVXI arithmetic insns to decodetree
c2bb7bb14c target/riscv: Convert RV64I load/store insns to decodetree
4d300c477c target/riscv: Convert RV32I load/store insns to decodetree
d3a535d4bd target/riscv: Convert RVXI branch insns to decodetree
24ce3b7417 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 24ce3b7417f1 (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit d3a535d4bd44 (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 4d300c477c0b (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit c2bb7bb14cd7 (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit e1eb41a99dd5 (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit 2816db131b63 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit e6a9b9eb652d (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit dfafa8effa70 (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit bba2c8eee088 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit 1672d35f9405 (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit eb79c070af0b (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit f65c343c002e (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit 0e2c2360fce4 (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 76465c2a96a8 (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit 1fba6972dea7 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit c26e3fb70684 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit e13984b314bd (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit b753bbf2f36f (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 0caa845fcc38 (target/riscv: Remove gen_jalr())
20/34 Checking commit bd963236b905 (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 18873e6110e2 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit cca0e9bc81ce (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit 57547a0f0d4f (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit acf34a297c4e (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit bfa8a3fdf72b (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit f0b34b584344 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 9de09ac79d0c (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 1252c0978f40 (target/riscv: Remove gen_system())
29/34 Checking commit 5c1ce86bf7d1 (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit d0651d3ced6a (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit c2f98fed12a3 (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit c378cd63324f (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit 149a4e77e75e (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 79d073df013a (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden