Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project

[Daniel P . Berrangé]

On Tue, Mar 26, 2019 at 06:39:40AM +0000, Peter Maydell wrote:
> On Mon, 25 Mar 2019 at 18:51, Eric Blake <address@hidden> wrote:
> > On 3/25/19 1:04 PM, Marc-André Lureau wrote:
> > > RFC: is this acceptable during freeze? (not a feature or code change)
> >
> > It's a big enough change that I'd personally feel more comfortable with
> > doing it in 4.1, but I'm not opposed if others want it in 4.0.
> 
> I think my question would be what the benefit of putting this into
> 4.0 is. If there's a compelling reason then we could, but my
> default view would be that we might as well leave to 4.1.

Even if it isn't a feature / code change, it is still a notable change to
our build system which thus has potential to cause regressions. We've
lived with bundled slirp for years, so I don't see a strong reason to
unbundle it when we're already at rc2.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|