[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec unless supported |
Date: |
Wed, 01 May 2019 16:26:57 +0100 |
User-agent: |
mu4e 1.3.1; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> Use tcg_can_emit_vec_op instead of just TCG_TARGET_HAS_neg_vec,
> so that we check the type and vece for the actual operation.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> tcg/optimize.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 5150c38a25..24faa06260 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -734,9 +734,13 @@ void tcg_optimize(TCGContext *s)
> } else if (opc == INDEX_op_sub_i64) {
> neg_op = INDEX_op_neg_i64;
> have_neg = TCG_TARGET_HAS_neg_i64;
> - } else {
> + } else if (TCG_TARGET_HAS_neg_vec) {
> + TCGType type = TCGOP_VECL(op) + TCG_TYPE_V64;
> + unsigned vece = TCGOP_VECE(op);
> neg_op = INDEX_op_neg_vec;
> - have_neg = TCG_TARGET_HAS_neg_vec;
> + have_neg = tcg_can_emit_vec_op(neg_op, type, vece) > 0;
> + } else {
> + break;
> }
> if (!have_neg) {
> break;
--
Alex Bennée
- [Qemu-devel] [PATCH v2 00/29] tcg vector improvements, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 01/29] tcg: Implement tcg_gen_gvec_3i(), Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec unless supported, Richard Henderson, 2019/05/01
- Re: [Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec unless supported,
Alex Bennée <=
- [Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 04/29] tcg: Specify optional vector requirements with a list, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 05/29] tcg: Assert fixed_reg is read-only, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 08/29] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface, Richard Henderson, 2019/05/01