Re: [Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov

[Richard Henderson]

On 5/1/19 10:29 AM, Alex Bennée wrote:
>> +static inline bool tcg_out_mov(TCGContext *s, TCGType type,
>>                                 TCGReg ret, TCGReg arg)
>>  {
>> -    tcg_out_dat_reg(s, COND_AL, ARITH_MOV, ret, 0, arg, SHIFT_IMM_LSL(0));
>> +    if (ret != arg) {
>> +        tcg_out_dat_reg(s, COND_AL, ARITH_MOV, ret, 0, arg, 
>> SHIFT_IMM_LSL(0));
>> +    }
>> +    return true;
>>  }
> 
> You fix a mov folding here.. either mention in commit message or fix in
> a separate commit. I appreciate the other arches already do this.

Fair enough, I've split this out to a separate commit.
And, using tcg_out_mov_reg(s, COND_AL, reg, arg), which
is perhaps even clearer.


r~