[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec,
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded |
Date: |
Wed, 01 May 2019 16:56:59 +0100 |
User-agent: |
mu4e 1.3.1; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> Reviewed-by: David Hildenbrand <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> tcg/tcg-op-vec.c | 49 ++++++++++++++++++++++++++++++++----------------
> 1 file changed, 33 insertions(+), 16 deletions(-)
>
> diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c
> index 27f65600c3..cfb18682b1 100644
> --- a/tcg/tcg-op-vec.c
> +++ b/tcg/tcg-op-vec.c
> @@ -226,16 +226,6 @@ void tcg_gen_stl_vec(TCGv_vec r, TCGv_ptr b, TCGArg o,
> TCGType low_type)
> vec_gen_3(INDEX_op_st_vec, low_type, 0, ri, bi, o);
> }
>
> -void tcg_gen_add_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)
> -{
> - vec_gen_op3(INDEX_op_add_vec, vece, r, a, b);
> -}
> -
> -void tcg_gen_sub_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)
> -{
> - vec_gen_op3(INDEX_op_sub_vec, vece, r, a, b);
> -}
> -
> void tcg_gen_and_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)
> {
> vec_gen_op3(INDEX_op_and_vec, 0, r, a, b);
> @@ -296,11 +286,30 @@ void tcg_gen_eqv_vec(unsigned vece, TCGv_vec r,
> TCGv_vec a, TCGv_vec b)
> tcg_gen_not_vec(0, r, r);
> }
>
> +static bool do_op2(unsigned vece, TCGv_vec r, TCGv_vec a, TCGOpcode opc)
> +{
> + TCGTemp *rt = tcgv_vec_temp(r);
> + TCGTemp *at = tcgv_vec_temp(a);
> + TCGArg ri = temp_arg(rt);
> + TCGArg ai = temp_arg(at);
> + TCGType type = rt->base_type;
> + int can;
> +
> + tcg_debug_assert(at->base_type >= type);
> + can = tcg_can_emit_vec_op(opc, type, vece);
> + if (can > 0) {
> + vec_gen_2(opc, type, vece, ri, ai);
> + } else if (can < 0) {
> + tcg_expand_vec_op(opc, type, vece, ri, ai);
> + } else {
> + return false;
> + }
> + return true;
> +}
> +
> void tcg_gen_not_vec(unsigned vece, TCGv_vec r, TCGv_vec a)
> {
> - if (TCG_TARGET_HAS_not_vec) {
> - vec_gen_op2(INDEX_op_not_vec, 0, r, a);
> - } else {
> + if (!TCG_TARGET_HAS_not_vec || !do_op2(vece, r, a, INDEX_op_not_vec)) {
> TCGv_vec t = tcg_const_ones_vec_matching(r);
> tcg_gen_xor_vec(0, r, a, t);
> tcg_temp_free_vec(t);
> @@ -309,9 +318,7 @@ void tcg_gen_not_vec(unsigned vece, TCGv_vec r, TCGv_vec
> a)
>
> void tcg_gen_neg_vec(unsigned vece, TCGv_vec r, TCGv_vec a)
> {
> - if (TCG_TARGET_HAS_neg_vec) {
> - vec_gen_op2(INDEX_op_neg_vec, vece, r, a);
> - } else {
> + if (!TCG_TARGET_HAS_neg_vec || !do_op2(vece, r, a, INDEX_op_neg_vec)) {
> TCGv_vec t = tcg_const_zeros_vec_matching(r);
> tcg_gen_sub_vec(vece, r, t, a);
> tcg_temp_free_vec(t);
> @@ -409,6 +416,16 @@ static void do_op3(unsigned vece, TCGv_vec r, TCGv_vec a,
> }
> }
>
> +void tcg_gen_add_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)
> +{
> + do_op3(vece, r, a, b, INDEX_op_add_vec);
> +}
> +
> +void tcg_gen_sub_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)
> +{
> + do_op3(vece, r, a, b, INDEX_op_sub_vec);
> +}
> +
> void tcg_gen_mul_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)
> {
> do_op3(vece, r, a, b, INDEX_op_mul_vec);
--
Alex Bennée
- [Qemu-devel] [PATCH v2 00/29] tcg vector improvements, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 01/29] tcg: Implement tcg_gen_gvec_3i(), Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec unless supported, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded, Richard Henderson, 2019/05/01
- Re: [Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded,
Alex Bennée <=
- [Qemu-devel] [PATCH v2 04/29] tcg: Specify optional vector requirements with a list, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 05/29] tcg: Assert fixed_reg is read-only, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov, Richard Henderson, 2019/05/01
- [Qemu-devel] [PATCH v2 08/29] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface, Richard Henderson, 2019/05/01