[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/11] qapi: add failover negotiated event
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 06/11] qapi: add failover negotiated event |
Date: |
Fri, 25 Oct 2019 07:35:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
We ask patch submitters to cc: subject matter experts for review. You
did. When such patches touch the QAPI schema, it's best to cc the qapi
schema maintainers (Eric Blake and me) as well, because we can't require
all subject matter experts to be fluent in the QAPI schema language and
conventions. I found this one more or less by chance.
Jens Freimann <address@hidden> writes:
> This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY
> feature was not negotiated during virtio feature negotiation. If this
> event is received it means any primary devices hotplugged before
> this were were never really added to QEMU devices.
Too many negations for my poor old brain to process.
>
> Signed-off-by: Jens Freimann <address@hidden>
> ---
> qapi/net.json | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/qapi/net.json b/qapi/net.json
> index 728990f4fb..8c5f3f1fb2 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -737,3 +737,19 @@
> ##
> { 'command': 'announce-self', 'boxed': true,
> 'data' : 'AnnounceParameters'}
> +
> +##
> +# @FAILOVER_NEGOTIATED:
> +#
> +# Emitted when VIRTIO_NET_F_STANDBY was negotiated during feature negotiation
> +#
> +# Since: 4.2
> +#
> +# Example:
> +#
> +# <- { "event": "FAILOVER_NEGOTIATED",
> +# "data": {} }
> +#
> +##
> +{ 'event': 'FAILOVER_NEGOTIATED',
> + 'data': {} }
The commit message at least tries to explain intended use. The doc
string does not. Should it?
- Re: [PATCH v5 02/11] pci: add option for net failover, (continued)
- [PATCH v5 03/11] pci: mark devices partially unplugged, Jens Freimann, 2019/10/23
- [PATCH v5 04/11] pci: mark device having guest unplug request pending, Jens Freimann, 2019/10/23
- [PATCH v5 05/11] qapi: add unplug primary event, Jens Freimann, 2019/10/23
- [PATCH v5 06/11] qapi: add failover negotiated event, Jens Freimann, 2019/10/23
- [PATCH v5 07/11] migration: allow unplug during migration for failover devices, Jens Freimann, 2019/10/23
- [PATCH v5 08/11] migration: add new migration state wait-unplug, Jens Freimann, 2019/10/23
- [PATCH v5 09/11] libqos: tolerate wait-unplug migration state, Jens Freimann, 2019/10/23
- [PATCH v5 10/11] net/virtio: add failover support, Jens Freimann, 2019/10/23
- [PATCH v5 11/11] vfio: unplug failover primary device before migration, Jens Freimann, 2019/10/23