[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/20] target/arm: Update MSR access for PAN
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v3 11/20] target/arm: Update MSR access for PAN |
|
Date: |
Fri, 7 Feb 2020 17:49:55 +0000 |
On Mon, 3 Feb 2020 at 14:47, Richard Henderson
<address@hidden> wrote:
>
> For aarch64, there's a dedicated msr (imm, reg) insn.
> For aarch32, this is done via msr to cpsr; and writes
> from el0 are ignored.
>
> Since v8.0, the CPSR_RESERVED bits have been allocated.
> We are not yet implementing ARMv8.0-SSBS or ARMv8.4-DIT,
> so retain CPSR_RESERVED for now, so that the bits remain RES0.
...we removed CPSR_RESERVED in patch 8...
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> v2: Move regdef to file scope; merge patch for CPSR_RESERVED:
> do not remove CPSR_SSBS from CPSR_RESERVED yet, mask PAN
> from CPSR if feature not enabled (pmm).
> v3: Update for cpsr_valid_mask etc.
> ---
> target/arm/cpu.h | 2 ++
> target/arm/internals.h | 6 ++++++
> target/arm/helper.c | 21 +++++++++++++++++++++
> target/arm/translate-a64.c | 14 ++++++++++++++
> 4 files changed, 43 insertions(+)
Other than fixing up the commit message
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [PATCH v3 08/20] target/arm: Remove CPSR_RESERVED, (continued)
- [PATCH v3 09/20] target/arm: Tidy msr_mask, Richard Henderson, 2020/02/03
- [PATCH v3 06/20] target/arm: Replace CPSR_ERET_MASK with aarch32_cpsr_valid_mask, Richard Henderson, 2020/02/03
- [PATCH v3 10/20] target/arm: Introduce aarch64_pstate_valid_mask, Richard Henderson, 2020/02/03
- [PATCH v3 11/20] target/arm: Update MSR access for PAN, Richard Henderson, 2020/02/03
- Re: [PATCH v3 11/20] target/arm: Update MSR access for PAN,
Peter Maydell <=
- [PATCH v3 12/20] target/arm: Update arm_mmu_idx_el for PAN, Richard Henderson, 2020/02/03
- [PATCH v3 13/20] target/arm: Enforce PAN semantics in get_S1prot, Richard Henderson, 2020/02/03
- [PATCH v3 14/20] target/arm: Set PAN bit as required on exception entry, Richard Henderson, 2020/02/03
- [PATCH v3 15/20] target/arm: Implement ATS1E1 system registers, Richard Henderson, 2020/02/03
- [PATCH v3 16/20] target/arm: Enable ARMv8.2-ATS1E1 in -cpu max, Richard Henderson, 2020/02/03
- [PATCH v3 17/20] target/arm: Add ID_AA64MMFR2_EL1, Richard Henderson, 2020/02/03
- [PATCH v3 18/20] target/arm: Update MSR access to UAO, Richard Henderson, 2020/02/03