qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 26/31] target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPU


From: Peter Maydell
Subject: Re: [PULL 26/31] target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[]
Date: Thu, 30 Apr 2020 15:30:47 +0100

On Thu, 30 Apr 2020 at 12:52, Peter Maydell <address@hidden> wrote:
>
> From: Philippe Mathieu-Daudé <address@hidden>
>
> Suggested-by: Richard Henderson <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>

This causes compile errors on configs where the array
ends up empty:

/home/pm/qemu/target/arm/cpu.c: In function ‘arm_cpu_register_types’:
/home/pm/qemu/target/arm/cpu.c:2903:19: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]
     for (i = 0; i < ARRAY_SIZE(arm_cpus); ++i) {
                   ^

I've dropped the patch from the pullreq.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]