[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/9] build: Check that mlockall() exists
From: |
Thomas Huth |
Subject: |
Re: [PATCH v3 3/9] build: Check that mlockall() exists |
Date: |
Fri, 3 Jul 2020 17:13:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 03/07/2020 16.56, Peter Maydell wrote:
> From: David CARLIER <devnexen@gmail.com>
>
> Instead of assuming that all POSIX platforms provide mlockall(),
> test for it in configure. If the host doesn't provide this platform
> then os_mlock() will fail -ENOSYS, as it does already on Windows.
>
> This is necessary for Haiku, which does not have mlockall().
>
> Signed-off-by: David Carlier <devnexen@gmail.com>
> [PMM: Expanded commit message]
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> configure | 15 +++++++++++++++
> os-posix.c | 4 ++++
> 2 files changed, 19 insertions(+)
[...]
> diff --git a/os-posix.c b/os-posix.c
> index 3cd52e1e700..e02b566940c 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -337,6 +337,7 @@ bool is_daemonized(void)
>
> int os_mlock(void)
> {
> +#if defined CONFIG_MLOCKALL
Also missing the parentheses?
Thomas
- [PATCH v3 0/9] Build fixes for Haiku, Peter Maydell, 2020/07/03
- [PATCH v3 3/9] build: Check that mlockall() exists, Peter Maydell, 2020/07/03
- Re: [PATCH v3 3/9] build: Check that mlockall() exists,
Thomas Huth <=
- [PATCH v3 4/9] osdep.h: Always include <sys/signal.h> if it exists, Peter Maydell, 2020/07/03
- [PATCH v3 6/9] bswap.h: Include <endian.h> on Haiku for bswap operations, Peter Maydell, 2020/07/03
- [PATCH v3 5/9] osdep.h: For Haiku, define SIGIO as equivalent to SIGPOLL, Peter Maydell, 2020/07/03
- [PATCH v3 7/9] util/compatfd.c: Only include <sys/syscall.h> if CONFIG_SIGNALFD, Peter Maydell, 2020/07/03