Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only

[Thomas Huth]

On 06/07/2020 16.00, Eric Blake wrote:
> On 7/3/20 10:12 AM, Thomas Huth wrote:
> 
>>> +++ b/util/qemu-openpty.c
>>> @@ -35,7 +35,7 @@
>>>   #include "qemu/osdep.h"
>>>   #include "qemu-common.h"
>>>   -#if defined(__GLIBC__)
>>> +#if defined CONFIG_PTY
> 
>>
>> Shouldn't there be some parentheses around CONFIG_PTY here?
> 
> No, they are optional, and omitting them is more consistent with the
> CONFIG_BSD just below.

Thanks, TIL - I'm doing so many years of C programming already, and
until now I never noticed any code that does not use parentheses after
"defined" ...

 Thomas