[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem impleme
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation |
|
Date: |
Wed, 22 Jul 2020 11:13:48 +0100 |
|
User-agent: |
Mutt/1.14.5 (2020-06-23) |
On Wed, Jul 22, 2020 at 12:03:27PM +0200, Stefan Weil wrote:
> Am 22.07.20 um 08:28 schrieb Alex Bennée:
>
> > It seems GetPhysicallyInstalledSystemMemory isn't available in the
> > MinGW headers so we have to declare it ourselves. Compile tested only.
>
>
> It is available, at least for Mingw-w64 which I also use for cross
> builds on Debian, but is only included with _WIN32_WINNT >= 0x0601.
This would be equiv to requiring Windows 7 or newer
> Currently we set _WIN32_WINNT to 0x0600.
This is equiv to Windows 6 / Vista / Server 2008
So if we blindly declare GetPhysicallyInstalledSystemMemory ourselves,
then we're likely going to fail at runtime when QEMU is used on
Windows prior to Windows 7.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 01/12] shippable: add one more qemu to registry url, (continued)
- [PATCH v2 01/12] shippable: add one more qemu to registry url, Alex Bennée, 2020/07/22
- [PATCH v2 02/12] semihosting: defer connect_chardevs a little more to use serialx, Alex Bennée, 2020/07/22
- [PATCH v2 04/12] util: add qemu_get_host_physmem utility function, Alex Bennée, 2020/07/22
- [PATCH v2 03/12] semihosting: don't send the trailing '\0', Alex Bennée, 2020/07/22
- [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Alex Bennée, 2020/07/22
- [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation, Alex Bennée, 2020/07/22
- Re: [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation, Yonggang Luo, 2020/07/22
[PATCH v2 08/12] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback, Alex Bennée, 2020/07/22
[PATCH v2 09/12] tests/docker: fix update command due to python3 str/bytes distinction, Alex Bennée, 2020/07/22
[PATCH v2 10/12] tests/docker: fix binfmt_misc image building, Alex Bennée, 2020/07/22