|
From: | Alex Bennée |
Subject: | Re: [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation |
Date: | Wed, 22 Jul 2020 12:33:47 +0100 |
User-agent: | mu4e 1.5.5; emacs 28.0.50 |
Stefan Weil <sw@weilnetz.de> writes: > Am 22.07.20 um 08:28 schrieb Alex Bennée: > >> It seems GetPhysicallyInstalledSystemMemory isn't available in the >> MinGW headers so we have to declare it ourselves. Compile tested only. > > > It is available, at least for Mingw-w64 which I also use for cross > builds on Debian, but is only included with _WIN32_WINNT >= 0x0601. > > Currently we set _WIN32_WINNT to 0x0600. That would explain why some people see things working if they build with visual studio (which I presume has a higher setting). We could just wrap the body of the function in: #if (_WIN32_WINNT >= 0x0601) much like in commands-win32.c? Of course it wouldn't even be compile tested (I used the fedora docker image). We should probably clean up the test-mingw code to work with both the fedora and debian-w[32|64] images. > > Regards, > > Stefan -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |