[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error
From: |
Greg Kurz |
Subject: |
Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error |
Date: |
Thu, 10 Sep 2020 18:26:58 +0200 |
On Wed, 9 Sep 2020 21:59:20 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> We leak local_err and don't report failure to the caller. It's
> definitely wrong, let's fix.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> blockdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 36bef6b188..74259527c1 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1797,8 +1797,7 @@ static void drive_backup_prepare(BlkActionState
> *common, Error **errp)
> aio_context_acquire(aio_context);
>
> if (set_backing_hd) {
> - bdrv_set_backing_hd(target_bs, source, &local_err);
> - if (local_err) {
> + if (bdrv_set_backing_hd(target_bs, source, errp) < 0) {
> goto unref;
> }
> }
- [PATCH 01/14] block: return status from bdrv_append and friends, (continued)
- [PATCH 01/14] block: return status from bdrv_append and friends, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 07/14] block/blklogwrites: drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/09