[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/14] block: check return value of bdrv_open_child and drop
From: |
Alberto Garcia |
Subject: |
Re: [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation |
Date: |
Thu, 17 Sep 2020 16:47:42 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 09 Sep 2020 08:59:19 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> This patch is generated by cocci script:
>
> @@
> symbol bdrv_open_child, errp, local_err;
> expression file;
> @@
>
> file = bdrv_open_child(...,
> - &local_err
> + errp
> );
> - if (local_err)
> + if (!file)
> {
> ...
> - error_propagate(errp, local_err);
> ...
> }
>
> with command
>
> spatch --sp-file x.cocci --macro-file scripts/cocci-macro-file.h \
> --in-place --no-show-diff --max-width 80 --use-gitgrep block
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
- [PATCH 00/14] block: deal with errp: part I, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 02/14] block: use return status of bdrv_append(), Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 01/14] block: return status from bdrv_append and friends, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Vladimir Sementsov-Ogievskiy, 2020/09/09
- [PATCH 07/14] block/blklogwrites: drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/09