Re: [PATCH 04/14] blockdev: fix drive_backup

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error

From:	Alberto Garcia
Subject:	Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error
Date:	Thu, 17 Sep 2020 15:56:35 +0200
User-agent:	Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Wed 09 Sep 2020 08:59:20 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> We leak local_err and don't report failure to the caller. It's
> definitely wrong, let's fix.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 01/14] block: return status from bdrv_append and friends, (continued)
- [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation, Greg Kurz, 2020/09/10
  - Re: [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation, Alberto Garcia, 2020/09/17
- [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd, Greg Kurz, 2020/09/10
  - Re: [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd, Alberto Garcia, 2020/09/17
- [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error, Greg Kurz, 2020/09/10
  - Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error, Alberto Garcia <=
- [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Alberto Garcia, 2020/09/17
    - Re: [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH 07/14] block/blklogwrites: drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 07/14] block/blklogwrites: drop error propagation, Greg Kurz, 2020/09/10
    - Re: [PATCH 07/14] block/blklogwrites: drop error propagation, Markus Armbruster, 2020/09/11
    - Re: [PATCH 07/14] block/blklogwrites: drop error propagation, Markus Armbruster, 2020/09/11
    - Re: [PATCH 07/14] block/blklogwrites: drop error propagation, Greg Kurz, 2020/09/11
    - Re: [PATCH 07/14] block/blklogwrites: drop error propagation, Markus Armbruster, 2020/09/11
  - Re: [PATCH 07/14] block/blklogwrites: drop error propagation, Ari Sundholm, 2020/09/10

Prev by Date: Re: [PATCH 2/3] block: add logging facility for long standing IO requests
Next by Date: Re: [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd
Previous by thread: Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error
Next by thread: [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface
Index(es):
- Date
- Thread