[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 8/8] qapi: New -compat deprecated-input=crash
From: |
Markus Armbruster |
Subject: |
[PATCH v5 8/8] qapi: New -compat deprecated-input=crash |
Date: |
Mon, 14 Sep 2020 10:48:02 +0200 |
Policy "crash" calls abort() when deprecated input is received.
Bugs in integration tests may mask the error from policy "reject".
Provide a larger hammer: crash outright. Masking that seems unlikely.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/compat.json | 3 ++-
qapi/qmp-dispatch.c | 1 +
qapi/qobject-input-visitor.c | 1 +
qemu-options.hx | 4 +++-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/qapi/compat.json b/qapi/compat.json
index d2c02a21aa..936602dcc6 100644
--- a/qapi/compat.json
+++ b/qapi/compat.json
@@ -11,11 +11,12 @@
#
# @accept: Accept silently
# @reject: Reject with an error
+# @crash: abort() the process
#
# Since: 5.2
##
{ 'enum': 'CompatPolicyInput',
- 'data': [ 'accept', 'reject' ] }
+ 'data': [ 'accept', 'reject', 'crash' ] }
##
# @CompatPolicyOutput:
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 634e9c0a7d..9954894d95 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -139,6 +139,7 @@ QDict *qmp_dispatch(const QmpCommandList *cmds, QObject
*request,
"Deprecated command %s disabled by policy",
command);
goto out;
+ case COMPAT_POLICY_INPUT_CRASH:
default:
abort();
}
diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c
index 91e2d84ad2..d21ba0db8e 100644
--- a/qapi/qobject-input-visitor.c
+++ b/qapi/qobject-input-visitor.c
@@ -680,6 +680,7 @@ static bool qobject_input_deprecated_accept(Visitor *v,
const char *name,
error_setg(errp, "Deprecated parameter '%s' disabled by policy",
name);
return false;
+ case COMPAT_POLICY_INPUT_CRASH:
default:
abort();
}
diff --git a/qemu-options.hx b/qemu-options.hx
index bb0c6bb70e..f36d2073e5 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3392,7 +3392,7 @@ DEFHEADING()
DEFHEADING(Debug/Expert options:)
DEF("compat", HAS_ARG, QEMU_OPTION_compat,
- "-compat
[deprecated-input=accept|reject][,deprecated-output=accept|hide]\n"
+ "-compat
[deprecated-input=accept|reject|crash][,deprecated-output=accept|hide]\n"
" Policy for handling deprecated management interfaces\n",
QEMU_ARCH_ALL)
SRST
@@ -3403,6 +3403,8 @@ SRST
Accept deprecated commands and arguments
``deprecated-input=reject``
Reject deprecated commands and arguments
+ ``deprecated-input=crash``
+ Crash on deprecated command
``deprecated-output=accept`` (default)
Emit deprecated command results and events
``deprecated-output=hide``
--
2.26.2
- [PATCH v5 6/8] qapi: Implement deprecated-input=reject for QMP commands, (continued)
- [PATCH v5 6/8] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2020/09/14
- [PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2020/09/14
- [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces, Markus Armbruster, 2020/09/14
- [PATCH v5 8/8] qapi: New -compat deprecated-input=crash,
Markus Armbruster <=
- [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2020/09/14
- [PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2020/09/14
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces, Richard W.M. Jones, 2020/09/21
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces, Peter Maydell, 2020/09/21