[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 8/8] qapi: New -compat deprecated-input=crash

From: Eric Blake
Subject: Re: [PATCH v5 8/8] qapi: New -compat deprecated-input=crash
Date: Mon, 14 Sep 2020 10:58:55 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/14/20 3:48 AM, Markus Armbruster wrote:
Policy "crash" calls abort() when deprecated input is received.

Bugs in integration tests may mask the error from policy "reject".
Provide a larger hammer: crash outright.  Masking that seems unlikely.

Signed-off-by: Markus Armbruster <armbru@redhat.com>

+++ b/qemu-options.hx
@@ -3392,7 +3392,7 @@ DEFHEADING()
  DEFHEADING(Debug/Expert options:)
DEF("compat", HAS_ARG, QEMU_OPTION_compat,
-    "-compat 
+    "-compat 
      "                Policy for handling deprecated management interfaces\n",
@@ -3403,6 +3403,8 @@ SRST
          Accept deprecated commands and arguments
          Reject deprecated commands and arguments
+    ``deprecated-input=crash``
+        Crash on deprecated command

Missing 'and arguments'?

Reviewed-by: Eric Blake <eblake@redhat.com>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]