[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] python: add .gitignore
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 4/5] python: add .gitignore |
|
Date: |
Wed, 28 Oct 2020 09:22:30 +0000 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Oct 28, 2020 at 10:16:33AM +0100, Markus Armbruster wrote:
> Thomas Huth <thuth@redhat.com> writes:
>
> > On 27/10/2020 23.38, John Snow wrote:
> >> Ignore build and package output (build, dist, qemu.egg-info);
> >> effectively these are "in-tree" builds of a kind.
> >
> > Since we recently moved away from in-tree builds, could these also be made
> > out-of-tree only?
>
> The build should only write to the per-build spaces: the build tree,
> per-build scratch in /tmp, ... Writing to shared space such as the
> source tree can break parallel independent builds. I consider that a
> bug.
Or worse it will simply fail when contributors have the source tree
as a read-only filesystem.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 1/5] python: add pytest and tests, (continued)
[PATCH 2/5] python: add excluded dirs to flake8 config, John Snow, 2020/10/27
[PATCH 4/5] python: add .gitignore, John Snow, 2020/10/27
Re: [PATCH 4/5] python: add .gitignore, John Snow, 2020/10/28
Re: [PATCH 4/5] python: add .gitignore, John Snow, 2020/10/28
[PATCH 5/5] gitlab: add python linters to CI, John Snow, 2020/10/27